Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp for multi-threading #108

Merged
merged 84 commits into from
May 22, 2020
Merged

Revamp for multi-threading #108

merged 84 commits into from
May 22, 2020

Conversation

Garvys
Copy link
Collaborator

@Garvys Garvys commented May 6, 2020 •
edited
Loading

  • W is now a trait parameter of all the Fst traits instead of an associated type.
  • Re-organized most of the algorithms into their own modules.
  • All the lazy fsts except rm_epsilon are now Send and Sync.
  • Remove the TrIterator in favor of the get_trs method in the CoreFst trait.
  • final_weight method of the CoreFst trait now returns a copy instead of a reference.

Garvys added 30 commits May 5, 2020 13:50
@Garvys
Toggle off algorithms module in order to experiment
b7b07b2
@Garvys
Impl Fst for ConstFst and VectorFst with new Trs trait
9aee1dd
@Garvys
Implement MutableFst and AllocableFst for VectorFst
830992d
@Garvys
Implement FstIteratorMut
1bbe990
@Garvys
Finish implementing Iterators
10c849d
@Garvys
Remove Implem of MutableFst because not working as expected
1efd2dd
@Garvys
Fix MutableFst implem
417cb5b
@Garvys
Fix mutable iterator
ec86069
@Garvys
Fix IntoIter implemenration
9123add
@Garvys
Save work : start moving W from associated type to trait parameter
48f2a08
@Garvys
Move Semiring from associated type to trait param
422fbfb
@Garvys
Start migration work in algorithms module
8821003
@Garvys
Save work
ca4f604
@Garvys
Continue migration
9b927e0
@Garvys
Finish migration except for lazyfst
426b9fa
@Garvys
Start working on cache revamp
0961dcc
@Garvys
Final_weight: returns copy of weight instead of ref
8be702f
@Garvys
Implement CoreFst for LazyFst
92eed6b
@Garvys
Implement StateIterator for LazyFst
608ae73
@Garvys
Implement FstIterator for LazyFst
6ff57ab
@Garvys
Implement Fst trait for LazyFst
4aaf863
@Garvys
Force TrsVec in LazyFst
818bf8d
@Garvys
Implement FstOp for ReplaceFstImpl
b523457
@Garvys
Move new structs/traits introduced in the LazyFst revamp in its own m…
f251b2e 
…odule
@Garvys
Split replace into multiple files into its own module
6b469e4
@Garvys
Implement Fst for ReplaceFst new type
40bbba4
@Garvys
Implemement thread safe StateTable
0af1386
@Garvys
Implement Fst for UnionFst
b32e279
@Garvys
Implement Fst for ClosureFst and ConcatFst
18ebbdc
@Garvys
Fmt
3fa7403
Garvys added 25 commits May 18, 2020 19:24
@Garvys
Make tests compile again
df12243
@Garvys
Implement FinalStatesIterator
1298f8c
@Garvys
Add back removed file
abb9e9f
@Garvys
Migrate RmEpsilonFst to FstOp API + remove old cache module
8256b71
@Garvys
Fix index bug in OpenFstIterator
ca52db3
@Garvys
Fix None unwrapping in composition
67ab6f5
@Garvys
Working on fixing the tests
7caa99d
@Garvys
Fix tests composition
573e28e
@Garvys
Updated readme
8484291
@Garvys
Patch ordered-iter
7c6b77f
@Garvys
Get rid of mutex on num_known_states
f63f31d
@Garvys
Add back trsort tests
96bc6c0
@Garvys
Add test sync on lazy fsts
b93cc0c
@Garvys
Fmt
4eef80b
@Garvys
Regex before openfst buld to use std::stable_sort instead of std::sort
ad44167
@Garvys
Encode has its own module now
26fce36
@Garvys
Fix bug in encode related to quantized wieghts
83a81e4
@Garvys
First shot at fixing shortest path failed tests -> use custom heap in…
8f4375e 
…stead of BinaryHeap
@Garvys
Fix shortest path : heap now matcher behaviour of c++ std::push_heap …
af1661d 
…and std::pop_heap
@Garvys
Add back determinize tests
ebe5eea
@Garvys
Remove label reachable tests
06d4c16
@Garvys
Change test logic for shortest path to fix inconsistencies between ma…
b4bf3bf 
…c and linux + implement check_path_in_fst
@Garvys
Merge pull request #109 from Garvys/task/test_upload_resources
2428204 
Change test logic for shortest path to fix inconsistencies between ma…
@Garvys
Replace tests are back in the crate
cf9422e
@Garvys
Merge pull request #110 from Garvys/task/test_upload_resources
3c400a3 
Replace tests are back in the crate
@Garvys Garvys marked this pull request as ready for review May 22, 2020 15:00
@Garvys Garvys merged commit 173b4a0 into master May 22, 2020
@Garvys Garvys deleted the task/new_fst_api branch May 22, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Garvys