Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition #79

Merged
merged 143 commits into from
Apr 7, 2020
Merged

Composition #79

merged 143 commits into from
Apr 7, 2020

Conversation

Garvys
Copy link
Collaborator

@Garvys Garvys commented Feb 6, 2020 •
edited
Loading

  • Implement FilterState
    • Implement IntegerFilterState
    • Implement WeightFilterState
    • Implement ListFilterState
    • Implement PairFilterState
    • Implement TrivialFilterState
  • Implement Matcher
    • Implement SortedMatcher
      ....
  • Implement ComposeFilter
    • Implement NullComposeFilter
    • Implement TrivialComposeFilter
    • Implement SequenceComposeFilter
    • Implement AltSequenceComposeFilter
    • Implement MatchComposeFilter
    • Implement NoMatchComposeFilter
    • Implement MultiEpsComposeFilter
  • Implement MatcherFst
    ...
  • Implement Composition
  • Implement CompositionFst

Garvys added 29 commits April 2, 2020 17:12
@Garvys
Implement FilterStates
fea0809
@Garvys
Start implementing Matcher
c0bda93
@Garvys
No_STATE_ID is now an usize
560a623
@Garvys
eps_loop SortedMatcher
5fe0156
@Garvys
Implement SortedMatcher + tests
4265327
@Garvys
Add ComposeFilter trait + implement NullComposeFilter and TrivialComp…
2e7096f 
…oseFilter
@Garvys
Implement SequenceComposeFilter
9d414c6
@Garvys
Implement AltSequenceComposeFilter
6f46c30
@Garvys
Implement MatchComposeFilter
97036b1
@Garvys
Implement NoMatchComposeFilter
c5a0897
@Garvys
Implement MultiEpsMatcher
4cbb685
@Garvys
Impl ComposeFstImpl
d515657
@Garvys
Impl ComputeFinal in ComposeFstImpl
b78e2dd
@Garvys
Impl Expand for ComposeFstImpl
d65d6e1
@Garvys
Implement match_arc in ComposeFstImpl
4bd089e
@Garvys
Finish implementing ComposeFstImpl
5603088
@Garvys
Constructor ComposeFstImpl
1613b8f
@Garvys
Get rid of dynamic_fst macro in favor of static dispatch
696fd5e
@Garvys
Remove a lot of useless imports
a02ddd8
@Garvys
Fix issues partialeq
8cf04e1
@Garvys
Add compose and compose_with_config functions
fbb5282
@Garvys
Introduce IterItemMatcher to avoid autoref
8e4bc47
@Garvys
Add all the compose filters back in scope + fix implems
aa6135a
@Garvys
Plug all compose filters inside composition
e55051a
@Garvys
Fix tests SortedMatcher
ca5bba0
@Garvys
Start Lookahead matchers
ca6ae9d
@Garvys
Reorganize lookahead matchers
2183010
@Garvys
Start arc_lookeahead_matchers
208ca7e
@Garvys
Add possibility to specify matchers and compose filters in input
6624b2f
Garvys added 18 commits April 2, 2020 17:14
@Garvys
Fix implementation TrivialLookAheadMatcher
5046173
@Garvys
Add bigger test cases
d9f4e7c
@Garvys
Fix mistake whem computing fst properties : INITIAL_ACYCLIC and INITI…
0f48731 
…AL_CYCLIC were wrongly set
@Garvys
Add test condense
021adfc
@Garvys
Add properties computation inside DFS to fix properties computation
9676693
@Garvys
Fix issue in IntervalReachVisitor : invert indexes in the union
8efa0da
@Garvys
Fix StateReachable cyclic case: use the wrong fst after call to condense
d8ee1b2
@Garvys
Add StateReachable test
94da0c2
@Garvys
Add test LabelReachable
eb32206
@Garvys
Fix call to clear_label_prefix in LabelLookAheadMatcher
6a2a824
@Garvys
Fix issue with MatcherFlags in LabelLookAheadMatcher
7c515c7
@Garvys
Fix issue with borrow_mut in LabelLookAheadMatcher
323049d
@Garvys
Add more tests in LabelReachable directly using a LookAhead fst
d06cf15
@Garvys
Fix MatcherFlags : typo on bitshift
a8b320b
@Garvys
Fix issue compute_final in ComposeFstInpl : zero_weight => not final
4d044ca
@Garvys
Add another fsts to the test : Fst014
eefdb66
@Garvys
Fix bug union interval sets
3ff818b
@Garvys
Fix conflicts
15e707c
@Garvys Garvys marked this pull request as ready for review April 7, 2020 12:02
@Garvys Garvys merged commit ab8252e into master Apr 7, 2020
@Garvys Garvys deleted the task/composition branch April 7, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Garvys