Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge DeviceInfo into Device to simplify API #6

Closed
gary-rowe opened this issue Dec 30, 2014 · 2 comments
Closed

Merge DeviceInfo into Device to simplify API #6

gary-rowe opened this issue Dec 30, 2014 · 2 comments
Assignees
@gary-rowe
Milestone
Release 0.3.0

Comments

@gary-rowe
Copy link
Owner

There is no good reason to separate DeviceInfo from Device.
@gary-rowe gary-rowe self-assigned this Dec 30, 2014
@gary-rowe gary-rowe added this to the Release 0.3.0 milestone Dec 30, 2014
gary-rowe added a commit that referenced this issue Jan 29, 2015
@gary-rowe
#6 Merged DeviceInfo into Device and updated APIs
a30893d
gary-rowe added a commit that referenced this issue Jan 29, 2015
@gary-rowe
#6 Updated README for changed API
ae03c2c
@gary-rowe
Copy link
Owner Author

Performed the merge. Small change to the external API as a result.

@gary-rowe gary-rowe added the awaiting review This code is awaiting the original creator of the issue to review the solution and provide feedback label Jan 29, 2015
@gary-rowe gary-rowe mentioned this issue Jan 29, 2015
Closed
@gary-rowe
Copy link
Owner Author

Seen working in downstream projects (MultiBit Hardware).

@gary-rowe gary-rowe removed the awaiting review This code is awaiting the original creator of the issue to review the solution and provide feedback label Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gary-rowe gary-rowe

Labels
None yet
Projects
None yet
Milestone
Release 0.3.0
Development

No branches or pull requests
1 participant
@gary-rowe