Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated windows hidapi DLLs with libusb's hidapi #81

Closed
wants to merge 1 commit into from

Conversation

Ktar5
Copy link

@Ktar5 Ktar5 commented Oct 25, 2019

Multiple functions with the hidapi version currently used in the project do not work, such as simply opening a device on Windows 10. This update fixes that and other issues by using a newer version of hidapi.dll from https://github.com/libusb/hidapi which is the currently maintained fork of hidapi.

@Ktar5
Copy link
Author

Ktar5 commented Oct 25, 2019

This should fix #76 , #60 , #44 and most likely others.

@gary-rowe
Copy link
Owner

Thanks for the pull request! Unfortunately I can't merge it in due to it being Windows only and the native libraries need to be updated for all supported platforms. I'll add you to the AUTHORS file in recognition of your contribution, though.

I've made some changes to the develop branch which demonstrate how to cross compile the native hidapi code. Take a look at the README file FAQ.

@gary-rowe
Copy link
Owner

I'm re-opening this PR so it can act as a general point of review for the new hidapi libraries. They are awaiting review by anyone who has time to test different environments and devices.

@gary-rowe gary-rowe added the awaiting review This code is awaiting the original creator of the issue to review the solution and provide feedback label Oct 29, 2019
@Ktar5
Copy link
Author

Ktar5 commented Oct 29, 2019

I'll check it out later inthe week thanks!

@pwitiw
Copy link

pwitiw commented Jan 7, 2020

I use this lib in my app running on linux - barcode reader (working as a keyboard). I have to deploy the same app on windows environment. I wonder whether you handled windows issues regarding keyboard like devices (if not, then how long does it take?) or should i rewrite it to use usb4java. Thanks in advance for the answer.

@gary-rowe
Copy link
Owner

I've been able to update the cross-compilation environment to support generation of Windows DLLs so I'll close this PR.

@gary-rowe gary-rowe closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This code is awaiting the original creator of the issue to review the solution and provide feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants