Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pip install #1

Merged
merged 8 commits into from
Oct 4, 2016
Merged

support pip install #1

merged 8 commits into from
Oct 4, 2016

Conversation

robertwenquan
Copy link
Contributor

@robertwenquan robertwenquan commented Sep 9, 2016

This is to make the repo pip installable, locally or from the github.

  • build wheel from source code
  • pip install . from source code
  • pip install frmo the git repo

changed the setup.py to use setuptools so you can build wheel from the repo

$ python setup.py bdist_wheel
/Users/robertwen/virtualenv/v1/lib/python2.7/site-packages/setuptools/dist.py:364: UserWarning: Normalizing '0.03' to '0.3'
  normalized_version,
running bdist_wheel
running build
running build_ext
skipping './python-lapjv/python_lapjv.cpp' Cython extension (up-to-date)
installing to build/bdist.macosx-10.11-x86_64/wheel
running install
running install_lib
creating build/bdist.macosx-10.11-x86_64/wheel
copying build/lib.macosx-10.11-x86_64-2.7/lapjv.so -> build/bdist.macosx-10.11-x86_64/wheel
running install_egg_info
running egg_info
writing python_lapjv.egg-info/PKG-INFO
writing top-level names to python_lapjv.egg-info/top_level.txt
writing dependency_links to python_lapjv.egg-info/dependency_links.txt
reading manifest file 'python_lapjv.egg-info/SOURCES.txt'
writing manifest file 'python_lapjv.egg-info/SOURCES.txt'
Copying python_lapjv.egg-info to build/bdist.macosx-10.11-x86_64/wheel/python_lapjv-0.3-py2.7.egg-info
running install_scripts
creating build/bdist.macosx-10.11-x86_64/wheel/python_lapjv-0.3.dist-info/WHEEL

moved the setup.py to the top repo level so you can pip install from git

$ pip install git+git://github.com/robertwenquan/lapjv.git

@gatagat
Copy link
Owner

gatagat commented Sep 13, 2016

Hi Robert,

the patch works for me under Debian, but I have some compilation issues under MacOS. I should have some time later this week, so I'll try to patch it.

Thanks for contributing!

Best,
Tomas

@robertwenquan
Copy link
Contributor Author

Hi Tomas,

Glad to help.

The mac failure may not be contributed by this patch. Actually the python setup.py build failed on some of my colleagues mac with Xcode 7.3.1 while it works fine with Xcode 7.3

Let me know if I can help with troubleshooting the platform issue as we have a variety of os versions company wise.

Best,
Robert

@gatagat gatagat merged commit 58b611f into gatagat:master Oct 4, 2016
@gatagat
Copy link
Owner

gatagat commented Oct 4, 2016

I finally got some time to work on this. The current version seems to be ok on both linux and mac that I have access to. Could you give it a try on some of your systems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants