support isolated build via pyproject #53
Open
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I know this project is largely in maintenance mode now, but I'm helping someone who very much likes using it and I'm trying to help make their project easier to install. One hurdle to that is the fact that you can't pip install lap into a fresh environment without first installing numpy/cython. PEPs 517/518 provide a solution for that, and have been implemented here by adding a pyproject.toml file.
I think these are the minimum changes needed to support
pip install lapwithout making any assumptions about the existing environment. I hope you'll consider this small change and push an updated sdist to pypi (i updated theRELEASING.mdguide accordingly)