Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove banner.txt #38

Closed
jstueckrath opened this issue Mar 3, 2020 · 2 comments · Fixed by #58
Closed

Remove banner.txt #38

jstueckrath opened this issue Mar 3, 2020 · 2 comments · Fixed by #58
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jstueckrath
Copy link

I added multiselect-combo-box-flow to the (Maven) dependencies of a Spring Boot project and noticed that the application suddenly showed the MultiselectComboBox banner. I did not yet define any banner and it was no problem to replace it with an own banner, since those are loaded with higher priority. However, I would suggest to remove the banner.txt since such a behaviour is not what I would expect of a library-type dependency.

@gatanaso gatanaso added enhancement New feature or request good first issue Good for newcomers labels Mar 3, 2020
@gatanaso
Copy link
Owner

gatanaso commented Mar 3, 2020

Hi @jstueckrath

Thanks for reporting the issue. I think the banner has been auto-generated when initially creating the project via the vaadin plugin. I do agree that the component should probably not display a banner on the app level, even if the app has not set one.

@jstueckrath
Copy link
Author

@gatanaso You're welcome, I am happy to help. Thanks also for the your combo box implementation, it fits my requirements quite nicely.

mvysny added a commit to mvysny/multiselect-combo-box-flow that referenced this issue Jun 3, 2020
@mvysny mvysny mentioned this issue Jun 3, 2020
gatanaso pushed a commit that referenced this issue Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants