Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(464): add support for queueing async actions in background #544

Merged
merged 4 commits into from
May 30, 2024

Conversation

Hamsajj
Copy link
Contributor

@Hamsajj Hamsajj commented May 27, 2024

Ticket(s)

#464

Description

This is an alternative approach to this #519 which does not rely on any third-party library.

Uses Redis Pub/Sub as a backend for queuing async actions (if configured).
It will fall back to the normal goroutine if not configured to use Redis.

A consumer is added to gateway-plugin-sdk, which is used in tests to show how it can be used.

Related PRs

This PR is dependent to this one being merged and released gatewayd-io/gatewayd-plugin-sdk#34

@Hamsajj
Copy link
Contributor Author

Hamsajj commented May 27, 2024

This is in draft mode because it's tests need gatewayd-io/gatewayd-plugin-sdk#34 to be merged and released and can not build or run tests without it

@mostafa
Copy link
Member

mostafa commented May 28, 2024

@Hamsajj I update the SDK and dependencies and you need to rebase from main. I already did it locally, but I don't have permission to update your fork.

@Hamsajj Hamsajj force-pushed the 464 branch 2 times, most recently from 22a4b51 to 47ce29e Compare May 29, 2024 08:00
@Hamsajj Hamsajj marked this pull request as ready for review May 29, 2024 08:10
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👏

I just left a comment about the configuration.

config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hamsajj Thanks for your awesome contribution! 🙏

I tested it locally and found and fixed a bug and did some minor adjustments.

act/registry.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
@mostafa mostafa merged commit f032849 into gatewayd-io:main May 30, 2024
3 of 4 checks passed
@mostafa mostafa linked an issue May 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add queueing for async actions
2 participants