Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Flag Incorrect Default #1

Closed
ethanmick opened this issue Jan 26, 2019 · 0 comments
Closed

Upload Flag Incorrect Default #1

ethanmick opened this issue Jan 26, 2019 · 0 comments
Assignees
@ethanmick
Labels
bug Something isn't working

Comments

@ethanmick
Copy link
Contributor

Upload flag should be false by default.
@ethanmick ethanmick added the bug Something isn't working label Jan 26, 2019
@ethanmick ethanmick self-assigned this Jan 26, 2019
@ethanmick ethanmick mentioned this issue Jan 26, 2019
Closed
ethanmick added a commit that referenced this issue Feb 15, 2019
@ethanmick
Upload flag defaults to false
9cb6724 
With the new meaning of the upload flag, we should not do it by default,
as that would really defeat the purpose of listening to the file.
Instead, the flag will often be used by the client as a seperate
execution and upload the file while the parser is still running.

Fix #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanmick ethanmick

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethanmick