Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global css #110

Merged
merged 20 commits into from
Oct 27, 2019
Merged

Global css #110

merged 20 commits into from
Oct 27, 2019

Conversation

rubenLozanoMar
Copy link
Contributor

Spanish translation to global-css file

gusma
gusma previously requested changes Oct 23, 2019
Copy link
Contributor

@gusma gusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Hola @rubenLozanoMar ! Estaría bueno que desdobles los archivos en distintos pull requests y que esos pull requests estén en branches distintas. ¿Será posible hacer este cambio?

@rubenLozanoMar
Copy link
Contributor Author

He creado 4 ramas, una para cada archivo traducido, como me lo dijisteis cuando lo hice en una todas.

@xmartinezpujol xmartinezpujol added this to the Docs / Docs milestone Oct 23, 2019
@xmartinezpujol xmartinezpujol added the Ready for review Pull request is ready for a maintainer to review it label Oct 23, 2019
Copy link
Contributor

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @rubenLozanoMar gracias por la contribución, te deje unas sugerencias y referencias a la documentación MDN en Español, al agregar estas, estaríamos listos para hacer merge 🚀

docs/docs/global-css.md Outdated Show resolved Hide resolved
docs/docs/global-css.md Outdated Show resolved Hide resolved
docs/docs/global-css.md Outdated Show resolved Hide resolved
docs/docs/global-css.md Outdated Show resolved Hide resolved
@xmartinezpujol xmartinezpujol dismissed stale reviews from Darking360 and gusma October 27, 2019 09:25

Cambios realizados

@xmartinezpujol xmartinezpujol merged commit 3c15011 into gatsbyjs:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Pull request is ready for a maintainer to review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants