Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: React version not specified in eslint-plugin-react settings. #10967

Closed
antoinerousseau opened this issue Jan 10, 2019 · 3 comments
Closed
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@antoinerousseau
Copy link
Contributor

antoinerousseau commented Jan 10, 2019

Description

I get the warning when running gatsby develop

Steps to reproduce

I'm using the default starter. I run:

gatsby develop

Expected result

No warning

Actual result

Warning: React version not specified in eslint-plugin-react settings.
See https://github.com/yannickcr/eslint-plugin-react#configuration

Note that it's nothing critical, it works anyway.

Environment

  System:
    OS: macOS 10.14.2
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 8.11.3 - /usr/local/bin/node
    Yarn: 1.12.3 - /usr/local/bin/yarn
    npm: 6.5.0 - /usr/local/bin/npm
  Languages:
    Python: 2.7.15 - /usr/local/bin/python
  Browsers:
    Chrome: 71.0.3578.98
    Safari: 12.0.2
  npmPackages:
    gatsby: ^2.0.76 => 2.0.90
    gatsby-image: ^2.0.20 => 2.0.25
    gatsby-plugin-manifest: ^2.0.9 => 2.0.13
    gatsby-plugin-offline: ^2.0.16 => 2.0.21
    gatsby-plugin-react-helmet: ^3.0.2 => 3.0.5
    gatsby-plugin-sharp: ^2.0.14 => 2.0.17
    gatsby-source-filesystem: ^2.0.8 => 2.0.13
    gatsby-transformer-sharp: ^2.1.8 => 2.1.10
  npmGlobalPackages:
    gatsby-cli: 2.4.8
@sidharthachatterjee sidharthachatterjee added type: upstream Issues outside of Gatsby's control, caused by dependencies status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. labels Jan 10, 2019
@sidharthachatterjee
Copy link
Contributor

Thank you for opening this @antoinerousseau

We use eslint-config-react-app under the hood and this was fixed in it in facebook/create-react-app#6132

We'll update once they publish a new version 🙂

@iwfan
Copy link

iwfan commented Jan 29, 2019

After I added the gatsby-browser.js file, I also encountered the same warning.

@sidharthachatterjee
Copy link
Contributor

This is resolved now since eslint-config-react-app was published 4 days ago. Updating gatsby should get rid of the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

3 participants