Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Creator Showcase from gatsbyjs.org #19362

Closed
tesseralis opened this issue Nov 8, 2019 · 10 comments · Fixed by #19495
Closed

Remove Creator Showcase from gatsbyjs.org #19362

tesseralis opened this issue Nov 8, 2019 · 10 comments · Fixed by #19495
Labels
help wanted Issue with a clear description that the community can help with.

Comments

@tesseralis
Copy link
Contributor

Summary

Remove https://gatsbyjs.org/creators and all links to it.

Motivation

@tesseralis tesseralis added the help wanted Issue with a clear description that the community can help with. label Nov 8, 2019
@fk
Copy link
Contributor

fk commented Nov 8, 2019

(Thinking out loud after taking a quick look)

There's currently 38 entires in the creators.yml file.

AFAICS the only place we link to "Creators" from is https://www.gatsbyjs.org/contributing/submit-to-creator-showcase/. As I remember things, those contributing guidelines might be the one place where we ever talked about this section of .org? Not sure though …

While my spontaneous vote would have been "yes, let's remove it — this feels like dead code for a (long) while now", the idea (still) makes sense to me. And a couple of things that would increase exposure/value seem quite low-hanging:

  • We do map showcase site authors to creators already (and link to showcase items from the creator's profile, see e.g. https://www.gatsbyjs.org/creators/people/lekoarts), but we don't map starters yet.
  • We don't link from showcase entries to the creator profile though.
  • We already have bespoke guidelines to add to "Creators", and mention the mapping to "Showcase" entries there, but we don't do so vice versa in the "Showcase" contributing guidelines.

@marcysutton @shannonbux @calcsam @KyleAMathews How do you feel about this?

@muescha
Copy link
Contributor

muescha commented Nov 9, 2019

To spin more the idea from @fk:

  • Remove the creators index -> redirect to showcase

  • Put the current content of creators detail page 1:1 under each schowcase where it is the creator. - If there is more than 1 showcase then list also the other showcases as preview and link.

  • (As temporary?) we add a "moved permanent" Redirect from the contributors detail to the first showcase

But:

  • instead of a not so much used yaml we can include the content somehow into the showcase yaml?

Or:

  • Delete the content at all with no replacement

@shannonbux
Copy link
Contributor

Yeah, I think just deleting it and redirecting to site showcase is a great idea; I wouldn't worry about repurposing the content as long as we notify the 38 people that we're working on a better version of this in the future?

Since it's not linked to from anywhere else, I doubt many people visit it if at all!

@Yofamb
Copy link
Contributor

Yofamb commented Nov 13, 2019

I'm happy to work on this issue once everyone has decided the best approach

@Yofamb
Copy link
Contributor

Yofamb commented Nov 14, 2019

I've created a draft pull request with a first pass on removing the creator showcase. All tests pass and I believe i've removed everything. More thought needs go on the redirects.

@sidharthachatterjee
Copy link
Contributor

We've decided to remove the pages and links to it but keep the data for now.

@EnKrypt
Copy link
Contributor

EnKrypt commented Nov 26, 2019

As @shannonbux suggested, I think some sort of notification would have been nice.

I was wondering why the creator showcase was showing a 404 before finding this issue. As of now, it does not redirect.

@Yofamb
Copy link
Contributor

Yofamb commented Nov 27, 2019

I guess I missed doing the redirect from /creators to /showcase perhaps i'll do a PR for the fix.

@muescha
Copy link
Contributor

muescha commented Nov 27, 2019

i tried to use this splat for an redirect but don't get it work on my local machine with develop and build/serve:

  createRedirect({
    fromPath: `/creators/*`,
    toPath: `/showcase`,
    isPermanent: true,
  })

i see some configurations about the usage of /oldpage/* in the issues, but maybe it works only on netlify?

see #3782 (comment)

For anyone interested to redirect with wildcard, you just need to ensure you have the correct host config (netlify/apache. Gatsby does not really filter it out so it gives us some freedom.

For example:

createRedirect({
  fromPath: "/someLegacyPath/*",
  toPath: "https://newDomain.com/someLegacyPath/:splat",
})

:splat is something specific for Netlify redirects. (see netlify.com/docs/redirects/#splats)
Your redirect won't be "portable" but at least it will work in Netlify.

@sidharthachatterjee
Copy link
Contributor

Just had a chat with @KyleAMathews and we've decided to add the creator showcase back in #20198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants