fix(gatsby-plugin-sharp): throw error when not added to gatsby-config #21045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
reviewed
Jan 30, 2020
ascorbic
previously approved these changes
Jan 30, 2020
blainekasten
approved these changes
Feb 1, 2020
| @@ -40,7 +40,7 @@ const getImageSize = file => { | |||
| // There is no guarantee that the module resolved is the module executing! | |||
| // This can occur in mono repos depending on how dependencies have been hoisted. | |||
| // The direct require has been left only to avoid breaking changes. | |||
| let { boundActionCreators } = require(`gatsby/dist/redux/actions`) | |||
| let boundActionCreators | |||
There was a problem hiding this comment.
This implementation is weird. I know it’s not the scope of this. But can you explain to me why we inject the boundActionCreators? Is this the whole local Gatsby vs global Gatsby stuff?
There was a problem hiding this comment.
boundActionCreators was deprecated in v2. We can continue using it, but it’s recommended that one rename it to actions. Note that actions is what is passed in in most lifecycle APIs.
So the name boundActionCreators is largely a remnant of the past.
sidharthachatterjee
changed the title
sidharthachatterjee
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With jobs-api we need to make sure that gatsby-plugin-sharp is set inside the gatsby-config array. It should always have been this case, this shows a valid error when it happens.