should the build complete when exceptions throw?

[brandonmp]

When my build fails b/c of a plugin throwing an exception, the build seems to complete on Netlify & even goes as far as deploying the broken build. Here's some output from last time it happened:

1:17:40 PM: 

  Error: socket hang up
  
  - next_tick.js:138 _combinedTickCallback
    internal/process/next_tick.js:138:11
  
  - next_tick.js:180 process._tickCallback
    internal/process/next_tick.js:180:9
  
1:17:42 PM: success source and transform nodes — 17.172 s
1:17:44 PM: success building schema — 1.879 s
1:17:44 PM: success createLayouts — 0.017 s
1:17:44 PM: Starting: Blog pages.
1:17:45 PM: error Plugin default-site-plugin returned an error
1:17:45 PM: 

  Error: 
1:17:45 PM: success createPages — 0.052 s
1:17:45 PM: success createPagesStatefully — 0.070 s
1:17:45 PM: GraphQL Error Unknown field `allContentfulBusinessSchool` on type `RootQueryType`

  file: /opt/build/repo/src/layouts/index.js

   1 | 
   2 |     query getNavMenuSchoolLinks {
>  3 |         allContentfulBusinessSchool {
     |         ^
   4 |             edges {
   5 |                 node {
   6 |                     name
   7 |                 }
   8 |             }
   9 |         }
  10 |     }
  11 |
1:17:45 PM: success extract queries from components — 0.590 s

The original source of the error is a plugin I wrote, but I don't have any catch statements in the plugin, so if the plugin isn't swallowing the error, what's stopping it from crashing the build process (which I would assume is desired functionality)?

[KyleAMathews]

Nope! We should be failing on exceptions.

[blackwood]

Curious — is this issue still open? I have a similar build process, and am hesitating on using source plugins without knowing that the build can fail.

[ricopags]

Is this issue still open? Looking to use google sheets as a source but the plugin references this issue as being a deal breaker. Maybe there's another way the plugin could signal failure without using the built in methods?

[brandonmp]

@ricopags that's an idea (sheets plugin author here). i could add an option to call process.kill or something in the event of a failure.

it's a bit extreme, but i imagine that, for most ppl, shutting the whole thing down is preferable to deploying with broken data

[12finger]

any news on this @KyleAMathews , @brandonmp ?

[KyleAMathews]

This was fixed a while ago — if plugins throw an error, we kill the process (during builds) —

gatsby/packages/gatsby/src/utils/api-runner-node.js

Line 237 in 5acbe25

if (process.env.NODE_ENV === `production`) {

[antmonnier]

This warning should probably be removed: https://www.gatsbyjs.com/plugins/gatsby-source-google-sheets/#heads-up

[saaqibz]

This warning should probably be removed: https://www.gatsbyjs.com/plugins/gatsby-source-google-sheets/#heads-up

FYI was playing around with gatsby and noticed this warning is still there. Might be worth removing it to reduce confusion