-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should the build complete when exceptions throw? #2727
Comments
Nope! We should be failing on exceptions. |
Curious — is this issue still open? I have a similar build process, and am hesitating on using source plugins without knowing that the build can fail. |
Is this issue still open? Looking to use google sheets as a source but the plugin references this issue as being a deal breaker. Maybe there's another way the plugin could signal failure without using the built in methods? |
@ricopags that's an idea (sheets plugin author here). i could add an option to call it's a bit extreme, but i imagine that, for most ppl, shutting the whole thing down is preferable to deploying with broken data |
any news on this @KyleAMathews , @brandonmp ? |
This was fixed a while ago — if plugins throw an error, we kill the process (during builds) —
|
This warning should probably be removed: https://www.gatsbyjs.com/plugins/gatsby-source-google-sheets/#heads-up |
FYI was playing around with gatsby and noticed this warning is still there. Might be worth removing it to reduce confusion |
When my build fails b/c of a plugin throwing an exception, the build seems to complete on Netlify & even goes as far as deploying the broken build. Here's some output from last time it happened:
The original source of the error is a plugin I wrote, but I don't have any
catch
statements in the plugin, so if the plugin isn't swallowing the error, what's stopping it from crashing the build process (which I would assume is desired functionality)?The text was updated successfully, but these errors were encountered: