fix: query on demand loading indicator always active on preact. #29829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
chrsep
force-pushed
the
fix/preact-loading-indicator
branch
from
db0f116
to
cb332a8
Compare
wardpeet
approved these changes
Feb 28, 2021
wardpeet
added
topic: preact*
and removed
status: triage needed
vladar
pushed a commit
that referenced
this pull request
Feb 28, 2021
(cherry picked from commit fa1e2d6)
vladar
pushed a commit
that referenced
this pull request
Feb 28, 2021
ascorbic
pushed a commit
that referenced
this pull request
Mar 1, 2021
(cherry picked from commit fa1e2d6)
ascorbic
pushed a commit
that referenced
this pull request
Mar 1, 2021
This was referenced Mar 7, 2021
This was referenced Mar 9, 2021
This was referenced Apr 15, 2024
This was referenced May 16, 2024
This was referenced Oct 13, 2024
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the query on-demand loading indicator always being active when using gatsby with preact.
This is caused by preact not rendering attributes with a literal bool
falsevalue. Turning the bool value into a string before passing it to preact solved the issue.Related Issues
Fixes #29051