Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query on demand loading indicator always active on preact. #29829

Merged
merged 1 commit into from Feb 28, 2021
Merged

fix: query on demand loading indicator always active on preact. #29829

merged 1 commit into from Feb 28, 2021

Conversation

chrsep
Copy link
Contributor

@chrsep chrsep commented Feb 28, 2021

Description

This PR fixes the query on-demand loading indicator always being active when using gatsby with preact.
image

This is caused by preact not rendering attributes with a literal bool false value. Turning the bool value into a string before passing it to preact solved the issue.

Related Issues

Fixes #29051

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 28, 2021
@chrsep chrsep force-pushed the fix/preact-loading-indicator branch from db0f116 to cb332a8 Compare February 28, 2021 07:30
wardpeet
wardpeet approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! this works great. Thank you for fixing this!

@wardpeet wardpeet merged commit fa1e2d6 into gatsbyjs:master Feb 28, 2021
@wardpeet wardpeet added topic: preact* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 28, 2021
@wardpeet wardpeet added this to To cherry-pick in Release candidate via automation Feb 28, 2021
@vladar vladar added this to To cherry-pick in V2 Release hotfixes via automation Feb 28, 2021
@gatsbybot gatsbybot mentioned this pull request Feb 28, 2021
Merged
vladar pushed a commit that referenced this pull request Feb 28, 2021
@chrsep @vladar
fix: query on demand loading indicator always active on preact. (#29829)
7584327 
(cherry picked from commit fa1e2d6)
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Feb 28, 2021
vladar pushed a commit that referenced this pull request Feb 28, 2021
@chrsep
fix: query on demand loading indicator always active on preact. (#29829…
aafe584 
…) (#29836)

(cherry picked from commit fa1e2d6)

Co-authored-by: Chrisando Pramudhita <chrisep8@gmail.com>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Feb 28, 2021
@vladar vladar moved this from Backported to Archived in Release candidate Mar 1, 2021
@gatsbybot gatsbybot mentioned this pull request Mar 1, 2021
Merged
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
@chrsep @ascorbic
fix: query on demand loading indicator always active on preact. (#29829)
6db13cf 
(cherry picked from commit fa1e2d6)
@ascorbic ascorbic moved this from To cherry-pick to Backport PR opened in V2 Release hotfixes Mar 1, 2021
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
@chrsep
fix: query on demand loading indicator always active on preact. (#29829…
706a754 
…) (#29882)

(cherry picked from commit fa1e2d6)

Co-authored-by: Chrisando Pramudhita <chrisep8@gmail.com>
@pieh pieh moved this from Backport PR opened to Backported in V2 Release hotfixes Mar 4, 2021
This was referenced Mar 7, 2021
Closed
Merged
Closed
Closed
Closed
@pieh pieh moved this from Backported to Archived in V2 Release hotfixes Mar 8, 2021
This was referenced Mar 9, 2021
Closed
Closed
Closed
Closed
@impactyogi impactyogi mentioned this pull request Mar 26, 2024
Open
This was referenced Mar 26, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
This was referenced Mar 27, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Mar 28, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Apr 14, 2024
Open
@wizbit wizbit mentioned this pull request Apr 14, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 14, 2024
Open
@monizb monizb mentioned this pull request Apr 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Apr 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Apr 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
@monizb monizb mentioned this pull request Apr 29, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release candidate
Archived
V2 Release hotfixes
Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-preact]: Query on Demand, loading indicator always active
2 participants
@chrsep @wardpeet