[gatsby-transformer-sharp] Provide fragments without gatsby-image #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
This is unnecessarily restrictive - using the transformer without gatsby-image (e.g. just for image manipulation) seems like an entirely legitimate usecase and should be supported.
Agree! Thanks @stefanprobst!
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Sep 28, 2018
* 'master' of github.com:gatsbyjs/gatsby: chore(release): Publish fix: add missing html and body attributes from ssr apis to develop mode (gatsbyjs#8594) chore(www): bump gatsby version (gatsbyjs#8614) chore: upgrade Gatsby Version in Gatsbygram Readme (gatsbyjs#8604) fix(gatsby-dev-cli): wait for files to be copied before exiting (gatsbyjs#8387) fix: add missing GatsbyImageProps to TS defs (gatsbyjs#8606) chore: forgot frontmatter date change (gatsbyjs#8601) Add Hasura GraphQL engine example under third party (gatsbyjs#8584) blog: update incorrect post date (gatsbyjs#8600) Add gatsby-mdx-starter to the list of starters (gatsbyjs#8547) Draft graphiql doc (gatsbyjs#8599) Added redirect (gatsbyjs#8528) feat: provide fragments without gatsby-image (gatsbyjs#8459) updated CODEOWNERS (gatsbyjs#8591) Updates to sidebar (gatsbyjs#8539)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
gatsby-transformer-sharponly copies fragments whengatsby-imageis installed as well. This is unnecessarily restrictive - using the transformer without gatsby-image (e.g. just for image manipulation) seems like an entirely legitimate usecase and should be supported.