Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect picture when sharing Gatsby's site #9288

Closed
yeskunall opened this issue Oct 22, 2018 · 4 comments · Fixed by #9291
Closed

Incorrect picture when sharing Gatsby's site #9288

yeskunall opened this issue Oct 22, 2018 · 4 comments · Fixed by #9291
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@yeskunall
Copy link
Contributor

yeskunall commented Oct 22, 2018 •
edited

Description

This issue might be specific to Facebook Messenger, but might be a larger issues: if you share Gatsby's website in Facebook Messenger, you see what I believe is @calcsam's face! 😆

Steps to reproduce

Just share this link in Facebook Messenger.

Expected result

What should happen?

Should have seen Gatsby's logo, or something other than @calcsam (no offence, Sam! 😅)

Actual result

image

Environment

I'm running Chrome 69.0.3497.100, if that helps!
@Seldszar Seldszar mentioned this issue Oct 22, 2018
Closed
@Seldszar
Copy link
Contributor

The og:image metadata seems to be missing in the HTML for some reason. My guess is to add it and the image should be fixed.

@Seldszar Seldszar mentioned this issue Oct 22, 2018
Merged
@mikelax
Copy link
Contributor

mikelax commented Oct 22, 2018

nice @Seldszar . for completeness you may want to add a few additional meta tags to get better sharing support on other sites.
I made a similar PR in the gatsby store repo a little while ago.

gatsbyjs/store.gatsbyjs.org#142

@Seldszar
Copy link
Contributor

Will do! :)

greybax pushed a commit to greybax/gatsby that referenced this issue Oct 22, 2018
fix for gatsbyjs#9288
26b4848
@greybax greybax mentioned this issue Oct 22, 2018
Merged
@kakadiadarpan kakadiadarpan added the type: bug An issue or pull request relating to a bug in Gatsby label Oct 23, 2018
DSchau pushed a commit that referenced this issue Oct 23, 2018
@greybax @DSchau
update open graph meta tags attributes from name to property (#9302)
f335f0c 
Fix for issue #9288 
Replaced "name=og:<some-name>" -> "property=og<some-name>."
@oorestisime
Copy link
Contributor

closing this as PR was merged and problem seems fixed

DSchau pushed a commit that referenced this issue Nov 1, 2018
@Seldszar @DSchau
feat(www): better social sharing support (#9291)
9c481f4 
Fixes #9288 

This pull request fixes image issues when sharing pages, like explained in the quoted one.

Another good example is when we use the Sharing Debugger on the features page, it shows the Wordpress logo (https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fwww.gatsbyjs.org%2Ffeatures%2F).
jedrichards pushed a commit to jedrichards/gatsby that referenced this issue Nov 1, 2018
@greybax @jedrichards
update open graph meta tags attributes from name to property (gatsbyj…
34b5776 
…s#9302)

Fix for issue gatsbyjs#9288 
Replaced "name=og:<some-name>" -> "property=og<some-name>."
jedrichards pushed a commit to jedrichards/gatsby that referenced this issue Nov 1, 2018
@Seldszar @jedrichards
feat(www): better social sharing support (gatsbyjs#9291)
c75cf2b 
Fixes gatsbyjs#9288 

This pull request fixes image issues when sharing pages, like explained in the quoted one.

Another good example is when we use the Sharing Debugger on the features page, it shows the Wordpress logo (https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fwww.gatsbyjs.org%2Ffeatures%2F).
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
@greybax @gpetrioli
update open graph meta tags attributes from name to property (gatsbyj…
831a589 
…s#9302)

Fix for issue gatsbyjs#9288 
Replaced "name=og:<some-name>" -> "property=og<some-name>."
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
@Seldszar @gpetrioli
feat(www): better social sharing support (gatsbyjs#9291)
f81a659 
Fixes gatsbyjs#9288 

This pull request fixes image issues when sharing pages, like explained in the quoted one.

Another good example is when we use the Sharing Debugger on the features page, it shows the Wordpress logo (https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fwww.gatsbyjs.org%2Ffeatures%2F).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(www): better social sharing support
5 participants
@mikelax @Seldszar @oorestisime @kakadiadarpan @yeskunall