Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tach sync removes non-exixtent modules #236

Merged
merged 11 commits into from
Aug 7, 2024
Merged

tach sync removes non-exixtent modules #236

merged 11 commits into from
Aug 7, 2024

Conversation

tiluckdave
Copy link
Contributor

@tiluckdave tiluckdave commented Aug 7, 2024 •
edited
Loading

Fixes #145

@tiluckdave tiluckdave marked this pull request as draft August 7, 2024 07:58
@tiluckdave tiluckdave marked this pull request as ready for review August 7, 2024 08:18
@tiluckdave tiluckdave changed the title remove non-exixtent modules tach sync removes non-exixtent modules Aug 7, 2024
@tiluckdave
Copy link
Contributor Author

image

@tiluckdave
Copy link
Contributor Author

@emdoyle can you review

emdoyle
emdoyle requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@emdoyle emdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things, then this should be good to go. Thanks for doing this!

python/tach/cli.py Outdated Show resolved Hide resolved
python/tach/sync.py Outdated Show resolved Hide resolved
@emdoyle emdoyle merged commit 6906ba5 into gauge-sh:main Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdoyle emdoyle emdoyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync should delete modules which do not exist
2 participants
@tiluckdave @emdoyle