-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 'get_project_imports' to Rust extension [18.8x speedup] #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdoyle
force-pushed
the
find-imports-in-rust
branch
from
May 27, 2024 01:59
ca98d7b
to
7eb85f3
Compare
emdoyle
changed the title
Move 'get_project_imports' to Rust extension
Move 'get_project_imports' to Rust extension [8.8x speedup]
May 27, 2024
emdoyle
changed the title
Move 'get_project_imports' to Rust extension [8.8x speedup]
Move 'get_project_imports' to Rust extension [18.8x speedup]
May 28, 2024
caelean
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By far most of the time spent by
tach check
ortach sync
is inget_project_imports
, particularly on large projects.[this is
tach sync
on the Sentry codebase (~3000 Python files)]You can also see in that flamegraph that most of the time spent within import scanning is simply visiting all the nodes (even for essentially generic no-ops) and building the ASTs themselves.
This PR moves the implementation of
get_project_imports
to our Rust extension library, using theruff
Python AST parser and node visitor crates. The functionality is otherwise generally a direct translation of our Python code.[this is
tach sync
on the Sentry codebase (~3000 Python files) using Rust for import scanning]