-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion support fasthttp #2
Comments
Thanks. This should be easy since we already have |
If you need any 'help' for conversions between net/http look iris's source code or ask here. When you finish it I will add it to iris' readme as the recommended way to run api tests :) Thanks you, I'm waiting for this! |
I've added
Both implement I also added I have no experience with Iris, so I have no idea how one can obtain http handler from Iris or what is the proper way to integrate with it. If you could provide an example, I'll add it to httpexpect too. As for performance, currently
If performance will become a problem, we can start with locating and optimizing bottlenecks in httpexpect first, and after that we can implement (if still matters) more efficient communication with fasthttp. I don't need it for myself right now (my test suite works fast enough) but feel free to open new issue if you'll find a problem. |
@gavv Very good work, you're really fast thanks you, do you allow to PR the iris in the examples? it's less lines than echo's |
Why not, you're welcome. |
It's done, tests rans perfect but I didn't see really difference from other frameworks(bench=.) (normally Iris is far faster than this test shows) you have right, something happens with the Binder, maybe at the future you could improve that. Edit 2-Info: httpexpect now lives on the iris' readme on the Testing section, if you want add something like Thanks you again, you're awesome. |
Good! I've added a link to examples section in README. |
Support for fasthttp will be appreciated, nice job, don't stop don't relax!
The text was updated successfully, but these errors were encountered: