Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License not present in the imported fasthttp-contrib/websocket package #74

Closed
bharath-b23 opened this issue May 20, 2020 · 3 comments
Closed
Assignees
Labels
feature New feature or request
Milestone

Comments

@bharath-b23
Copy link

Hello,

github.com/fasthttp-contrib/websocket package imported in this project doesn't contain a license and implicitly makes this project to come under default copyright laws which means, that the project retain all rights to the source code and no one can reproduce, distribute, or create derivative works.

Though github.com/fasthttp-contrib/websocket is forked copy of github.com/gorilla/websocket, which has a proper license, I think we need github.com/fasthttp-contrib/websocket too to have a proper license, since it's being directly imported by this project.

Can we solve this issue by dropping github.com/fasthttp-contrib/websocket package or in anyother possible way.

Have also created an issue against github.com/fasthttp-contrib/websocket, but the project doesn't seem to be active for a year or more.

Thank you.

@gavv
Copy link
Owner

gavv commented Jun 3, 2020

Likely, we can just switch to https://github.com/fasthttp/websocket. I'll look at it in upcoming days.

@gavv gavv added the feature New feature or request label Jun 3, 2020
@gavv gavv self-assigned this Jun 3, 2020
@gavv gavv added this to the v2 milestone Jun 3, 2020
@gavv
Copy link
Owner

gavv commented Jun 4, 2020

Done. Pushed to master, v2, and tagged a new release v2.1.0. Also, the minimum supported Go version was bumped to Go 1.14.

@gavv gavv closed this as completed Jun 4, 2020
@bharath-b23
Copy link
Author

Gavv, Thank you for your time and efforts spent to resolve the observation reported.

@gavv gavv removed their assignment Dec 21, 2020
@gavv gavv self-assigned this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants