Convert some DateTime and Duration tests to be table driven

[PiotrLewandowski323]

Fixes #310

I've created the PR, but I'm not sure about 2 things:

• How to handle the test cases below in table driven style as they use different function to create the object than other test cases.

newDuration(newMockChain(t), nil).InList(time.Second).chain.assertFailed(t)
newDuration(newMockChain(t), nil).NotInList(time.Second).chain.assertFailed(t)

• I removed some test cases for InList tests, as I believe they were copied from InRange test cases and didn't test any edge cases, e.g.:

value.InList(time.Unix(0, 1234+1), time.Unix(0, 1234+2))
value.chain.assertFailed(t)
value.chain.clearFailed()

value.NotInList(time.Unix(0, 1234+1), time.Unix(0, 1234+2))
value.chain.assertNotFailed(t)
value.chain.clearFailed()

value.InList(time.Unix(0, 1234-2), time.Unix(0, 1234-1))
value.chain.assertFailed(t)
value.chain.clearFailed()

value.NotInList(time.Unix(0, 1234-2), time.Unix(0, 1234-1))
value.chain.assertNotFailed(t)
value.chain.clearFailed()

If any of these should be changed please let me know.

[coveralls]

Coverage: 95.02% (-0.2%) from 95.181% when pulling c697d3c on PiotrLewandowski323:issue-310 into 9e6c89d on gavv:master.

[gavv]

Hi, thanks for PR, will review in upcoming days.

newDuration(newMockChain(t), nil).InList(time.Second).chain.assertFailed(t)
newDuration(newMockChain(t), nil).NotInList(time.Second).chain.assertFailed(t)

these two tests can be just removed, they cover a deprecated feature of "unset" duration (when we pass nil to ctor), which will be removed in upcoming releases.

[gavv]

I removed some test cases for InList tests, as I believe they were copied from InRange test cases and didn't test any edge cases, e.g.:

Seems legit.

[gavv]

The patch looks good!

Could you please replace map of structs with slice of structs?

Here is recent discussion from chat (BTW welcome to join if you wish)

gavv — 02/27/2023 10:20 PM
@gpjservais I was debugging a test that has cases := map[string]struct {, and found it a bit inconvenient that subtests are executed in different order each invocation (for obvious reasons)

since it's a matter of a few lines, I think it would be nice to switch from maps of structs to slices of structs in future tests

(posting it to chat so that others could see the message too)

gpjservais — 02/27/2023 10:52 PM
Sounds good! I'll make sure to use slices of structs moving forward.

gavv — Today at 2:06 PM
@gpjservais FYI: cc1810b

[gavv]

Could you please also rename instance to tc? "tc" stands for "test case" and is used in most table tests in this lib.

[gavv]

Thanks!!