-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert some DateTime and Duration tests to be table driven #313
Conversation
Signed-off-by: PiotrLewandowski323 <lewandowski323@gmail.com>
Signed-off-by: PiotrLewandowski323 <lewandowski323@gmail.com>
Hi, thanks for PR, will review in upcoming days. newDuration(newMockChain(t), nil).InList(time.Second).chain.assertFailed(t)
newDuration(newMockChain(t), nil).NotInList(time.Second).chain.assertFailed(t) these two tests can be just removed, they cover a deprecated feature of "unset" duration (when we pass nil to ctor), which will be removed in upcoming releases. |
Seems legit. |
Signed-off-by: PiotrLewandowski323 <lewandowski323@gmail.com>
The patch looks good! Could you please replace map of structs with slice of structs? Here is recent discussion from chat (BTW welcome to join if you wish)
|
Could you please also rename |
Signed-off-by: PiotrLewandowski323 <lewandowski323@gmail.com>
Thanks!! |
Signed-off-by: PiotrLewandowski323 <lewandowski323@gmail.com>
Fixes #310
I've created the PR, but I'm not sure about 2 things:
If any of these should be changed please let me know.