Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-01 workshop #5

Merged
merged 13 commits into from
Mar 4, 2020
Merged

CSS-01 workshop #5

merged 13 commits into from
Mar 4, 2020

Conversation

fares98
Copy link
Collaborator

@fares98 fares98 commented Feb 18, 2020

No description provided.

@fares98 fares98 self-assigned this Feb 18, 2020
hshahwan
hshahwan previously approved these changes Feb 23, 2020
Copy link
Contributor

@mghada mghada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see Haneen's comments

hshahwan
hshahwan previously approved these changes Mar 1, 2020
@hshahwan hshahwan self-requested a review March 1, 2020 12:43
@hshahwan
Copy link
Collaborator

hshahwan commented Mar 1, 2020

@fares98 did you check this issue #8 Workshops guidelines for contributors ?
make sure that your readme has the schedule of the day.

background-color: black;
}
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use w3Schools examples to clarify and show them how this works exactly
https://www.w3schools.com/css/css_pseudo_elements.asp

it contains examples for all pseudo-classes and elements

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have these examples

example for every pseudo-element individually.

but I didn't use it because I discussed that with Haneen and we decided to use the examples that found in the workshop

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to find a good way to present the examples.
I have a suggestion, create a folder for examples that contains index.html and index.css and add all examples,
what do you think?
@MohammedYehia do you have any idea?

coursebook/session-03/resources.md Outdated Show resolved Hide resolved
@hshahwan
Copy link
Collaborator

hshahwan commented Mar 2, 2020

@fares98 could you check the request changes?

@fares98 fares98 requested a review from hshahwan March 3, 2020 11:26
@hshahwan
Copy link
Collaborator

hshahwan commented Mar 3, 2020

@MohammedYehia if you have time, please review this PR

@hshahwan hshahwan merged commit 24ba5c1 into master Mar 4, 2020
@hshahwan hshahwan deleted the session-03 branch March 4, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants