Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Test at HEAD #77

Closed
KosherBacon opened this issue Nov 30, 2017 · 4 comments
Closed

Failing Test at HEAD #77

KosherBacon opened this issue Nov 30, 2017 · 4 comments
Assignees
@gazbert
Labels
unit test code issue

Comments

@KosherBacon
Copy link

Wanted to begin trying this out. when I downloaded from HEAD and ran the gradlew clean build command the testEngineExecutesNextTradeCyclesAfterReceivingExchangeNetworkException test fails consistently for me. Fails here.

I'm running this on a Windows 10 machine. I got the same failure on a macOS machine as well.
@gazbert
Copy link
Owner

gazbert commented Nov 30, 2017 •
edited
Loading

Sounds like a timing issue in the wait for the bot to stop on diff architectures. Have you tried increasing the Thread.sleep(1000) value? Try pushing it up to 2000/3000.

Ideally, these unit tests need tweaking to wait in a loop for the bot to shutdown... I'll stick it on my list.

Not had timing issues to date on Debian, Ubuntu, and my Macbook Pro (High Sierra) - thank for spotting this.

@gazbert gazbert self-assigned this Nov 30, 2017
gazbert added a commit that referenced this issue Dec 4, 2017
@gazbert
#77 - Fix for unit test timing issues on some archs
ff2cd5c 
* Still need proper fix fo testEngineExecutesNextTradeCyclesAfterReceivingExchangeNetworkException()
@KosherBacon
Copy link
Author

2000 worked for me.

gazbert added a commit that referenced this issue Dec 9, 2017
@gazbert
#77 - All unit tests timings tweaked
dbd5eef
@gazbert
Copy link
Owner

gazbert commented Dec 9, 2017

Done. Ready for next release.

kgonia pushed a commit to kgonia/bxbot that referenced this issue Dec 15, 2017
@gazbert
gazbert#77 - Fix for unit test timing issues on some archs
71c4cb5 
* Still need proper fix fo testEngineExecutesNextTradeCyclesAfterReceivingExchangeNetworkException()
@gazbert
Copy link
Owner

gazbert commented Dec 24, 2017

Released.

@gazbert gazbert closed this as completed Dec 24, 2017
gazbert added a commit that referenced this issue Feb 21, 2018
@gazbert
#77 - another unit test timing expectation fix
dc1b7d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gazbert gazbert

Labels
unit test code issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KosherBacon @gazbert