Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes - Sendgrid #100

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Minor fixes - Sendgrid #100

merged 3 commits into from
Sep 11, 2023

Conversation

marcoshuck
Copy link
Collaborator

@marcoshuck marcoshuck commented Sep 11, 2023 •
edited
Loading

This PR fixes a small issue with:

  • Configuring from email
  • Error status when email was sent

@marcoshuck marcoshuck changed the title Fix how from email is set Minor fixes - Sendgrid Sep 11, 2023
AlejoAsd
AlejoAsd approved these changes Sep 11, 2023
View reviewed changes
mailing/sendgrid.go Outdated Show resolved Hide resolved
@marcoshuck @AlejoAsd
Update mailing/sendgrid.go
8c9657e 
Co-authored-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Marcos Huck <marcoshuck@users.noreply.github.com>
@marcoshuck marcoshuck marked this pull request as ready for review September 11, 2023 21:14
@marcoshuck marcoshuck merged commit 5856338 into main Sep 11, 2023
4 checks passed
@marcoshuck marcoshuck deleted the fix/from_email branch September 11, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejoAsd AlejoAsd AlejoAsd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoshuck @AlejoAsd