7 ➡️ 9 #2801
Merged
7 ➡️ 9 #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove X11 call from Gazebo 7 Approved-by: Steve Peters <scpeters@osrfoundation.org> Approved-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Fixed crash when collision size is zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Using ignition::math::isnan Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved error message Signed-off-by: ahcorde <ahcorde@gmail.com> * fixed method to get the name of the visual Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed else brackets Signed-off-by: ahcorde <ahcorde@gmail.com> * [Gazebo 9] Added test to check collisions equal to zero (#2788) * Added test to check collisions equal to zero Signed-off-by: ahcorde <ahcorde@gmail.com> * Included feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Update Visual_TEST.cc
|
@osrf-jenkins run tests please |
1 similar comment
|
@osrf-jenkins run tests please |
|
this seems to revert 98a5eb7 from a few years ago |
which was part of osrf/gazebo PR 2572: |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
This PR is now just fixing a typo and some changelog entries, no code changes. |
mabelzhang
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
gazebo7forward togazebo9. Nothing major, mainly just one PR.Includes #2800