Macros for generating cmd*.rb , conf/*.yaml files #270
Conversation
Signed-off-by: Harsh Mahesheka <harsh.mahesheka.eee20@iitbhu.ac.in>
harshmahesheka
requested review from
mxgrey,
j-rivero and
scpeters
as code owners
github-actions
bot
added
Gazebo 1️1️
harshmahesheka
force-pushed
the
harsh/add_macros
branch
from
1cccab1
to
db0605c
Compare
Signed-off-by: Harsh Mahesheka <harsh.mahesheka.eee20@iitbhu.ac.in>
harshmahesheka
force-pushed
the
harsh/add_macros
branch
from
db0605c
to
c9ab2d5
Compare
Signed-off-by: Harsh Mahesheka <harsh.mahesheka.eee20@iitbhu.ac.in>
Created PR's for removing boilerplates from gz-transport and gz-msgs |
|
Not that I'm completely against this PR but would like to clarify first what happened, follow up gazebosim/gz-tools#72 (comment) please. |
| ################################################# | ||
| # ign_generate_conf() | ||
| # Generate conf/*.yaml files for projects | ||
| macro(ign_generate_conf) |
There was a problem hiding this comment.
Can you change the name of the macro to be a little more descriptive? Maybe just including ign-tools in the name is sufficient, eg. ign_tools_generate_conf or ign_generate_conf_for_ign_tools. @j-rivero might have better suggestions.
There was a problem hiding this comment.
We can by cycling on this but I still have the feeling that adding functions that are intrinsic related to gz-tools should be done in that repository. Since @harshmahesheka mentioned that the instruction in the Gazebo meeting was to use this repo, I'm going to try to accommodate that the decision here:
- Following Split gzutils into functional pieces #344, I'll move these set of function to a new file.
- Consider not to include the new file automatically into the
find_package(gz-cmake)call and make it somehow optional. - The migration from Ign to Gz needs to be done
- As @azeey suggested let's find a good name for them, something like
gztools_generate_subcommands_filesand consider to merge both features in once since seems to be that both ruby and yaml files are highly linked.
| ################################################# | ||
| # ign_generate_cmd() | ||
| # Generate cmd*.rb files for projects | ||
| macro(ign_generate_cmd) |
There was a problem hiding this comment.
Can you change the name of the macro to be a little more descriptive in the same way as my comment above?
|
|
||
| ################################################# | ||
| # ign_generate_conf() | ||
| # Generate conf/*.yaml files for projects |
There was a problem hiding this comment.
Mention that these files are used by ign-tools.
| ################################################# | ||
| # ign_generate_conf() | ||
| # Generate conf/*.yaml files for projects | ||
| macro(ign_generate_conf) |
There was a problem hiding this comment.
Should we go ahead and use gz_ instead of ign_ since these are new macros?
|
I'm going to close this one since we did not get any feedback from the author in some months. Please feel free to reopen if you are interested into working in the points listed in #270 (comment) and I will happily help as much as I can. |
|
Sorry, I missed this. Currently, I am busy with my exams, I will work on these and get back to you sometime later. |
No worries, thanks @harshmahesheka . |
🎉 New feature
Closes gazebosim/gz-tools#72
Summary
Added Macros for generating cmd*.rb and conf/*.yaml files which decreases boilerplate code from repositories.
Checklist
codecheckpassed (See contributing)Test It
I have replaced the boilerplate code with macros in my fork here. You can build this and confirm that the correct cmd and conf are being generated and installed.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.