Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing headers #486

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Add missing headers #486

merged 2 commits into from
Sep 14, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Fixes gz-gui7-focal Build Status

Summary

Added the missing headers which were causing examples/standalone/point_cloud/point_cloud.cc compilation to fail.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine self-assigned this Sep 12, 2022
@jennuine jennuine added the bug Something isn't working label Sep 12, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #486 (081ec02) into gz-gui7 (b5f354a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           gz-gui7     #486   +/-   ##
========================================
  Coverage    67.82%   67.82%           
========================================
  Files           44       44           
  Lines         4826     4826           
========================================
  Hits          3273     3273           
  Misses        1553     1553           
Impacted Files Coverage Δ
src/plugins/camera_tracking/CameraTracking.cc 68.45% <ø> (ø)
src/plugins/grid_config/GridConfig.cc 22.35% <ø> (ø)
src/plugins/grid_config/GridConfig.hh 100.00% <ø> (ø)
src/plugins/image_display/ImageDisplay.cc 31.70% <ø> (ø)
...interactive_view_control/InteractiveViewControl.cc 17.88% <ø> (ø)
src/plugins/key_publisher/KeyPublisher.cc 56.52% <ø> (ø)
src/plugins/marker_manager/MarkerManager.cc 59.41% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.cc 65.61% <ø> (ø)
src/plugins/publisher/Publisher.cc 90.78% <ø> (ø)
src/plugins/screenshot/Screenshot.cc 30.12% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennuine jennuine merged commit 21fbf36 into gz-gui7 Sep 14, 2022
@jennuine jennuine deleted the jennuine/add_headers branch September 14, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants