Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split package in sdformat_to_mjcf and sdformat_mjcf_utils #31

Merged
merged 2 commits into from
May 18, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 18, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Superseed #27

  • Renamed sdformat_mjcf to sdformat_to_mjcf
  • Split utilities to a new package called sdformat_mjcf_utils

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@azeey
Copy link
Collaborator

azeey commented May 18, 2022

Let's go ahead with this for now. Per our discussion with @j-rivero, we might put both sdformat_to_mjcf and sdformat_mjcf_utils and sdformat_mjcf later to simplify package releasing.

@azeey azeey merged commit 4c7ba9d into main May 18, 2022
@azeey azeey deleted the ahcorde/split_package branch May 18, 2022 15:17
@azeey azeey mentioned this pull request May 18, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants