SDF to MJCF: Added light to links #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 95.75% 95.83% +0.08%
==========================================
Files 9 9
Lines 259 264 +5
==========================================
+ Hits 248 253 +5
Misses 11 11
Continue to review full report at Codecov.
|
9 tasks
azeey
approved these changes
May 19, 2022
scpeters
reviewed
May 19, 2022
| light.linear_attenuation_factor(), | ||
| light.quadratic_attenuation_factor()], | ||
| body_mjcf.light[0].attenuation) | ||
| assert_allclose([0.864937, -0.549277, 0.013397], |
There was a problem hiding this comment.
nit: it would be nice to compute this expected value based on the inputs (test_pose and [0.1, 0.2, 1])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
SDF to MJCF: Added light to links
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.