Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJCF to SDF: Added camera sensor #49

Merged
merged 15 commits into from
Jun 2, 2022
Merged

MJCF to SDF: Added camera sensor #49

merged 15 commits into from
Jun 2, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 26, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

It requires gazebosim/sdformat#997

Added camera sensor and it allows to export the world plugins. In Gazebo, the simulation requires the Sensor system plugin to be able to simulate sensors

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the needs upstream release Blocked by a release if an upstream library label May 26, 2022
@ahcorde ahcorde requested a review from azeey May 26, 2022 19:46
@ahcorde ahcorde self-assigned this May 26, 2022
@ahcorde ahcorde mentioned this pull request May 31, 2022
9 tasks
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #49 (2c75bc2) into main (fbb5399) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   97.41%   97.54%   +0.12%     
==========================================
  Files          17       18       +1     
  Lines         736      773      +37     
==========================================
+ Hits          717      754      +37     
  Misses         19       19              
Impacted Files Coverage Δ
..._to_sdformat/mjcf_to_sdformat/converters/sensor.py 100.00% <100.00%> (ø)
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 98.41% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb5399...2c75bc2. Read the comment docs.

@ahcorde ahcorde removed the needs upstream release Blocked by a release if an upstream library label Jun 1, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey June 2, 2022 17:32
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more test and I think this is ready!

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 7faaf8d into main Jun 2, 2022
@ahcorde ahcorde deleted the ahcorde/mjcf2sdf/sensors branch June 2, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants