Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert models from local paths #123

Closed
iche033 opened this issue May 1, 2020 · 7 comments · Fixed by #172
Closed

Insert models from local paths #123

iche033 opened this issue May 1, 2020 · 7 comments · Fixed by #172
Assignees
Labels
📜 blueprint Ignition Blueprint close the gap Features from Gazebo-classic enhancement New feature or request

Comments

@iche033
Copy link
Contributor

iche033 commented May 1, 2020

Currently models are downloaded from fuel (app.ignitionrobotics.org) and saved to fuel cache in ~/.ignition/fuel. The idea is to support pulling models locally without going through fuel.

Related design doc:
gazebosim/design#1

Related PRs:
https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-fuel-tools/pull-requests/123/page/1
https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-gazebo/pull-requests/532/page/1

@iche033 iche033 added the enhancement New feature or request label May 1, 2020
@iche033 iche033 added this to Inbox in Core development via automation May 1, 2020
@chapulina chapulina moved this from Inbox to To do in Core development May 4, 2020
@nkoenig
Copy link
Contributor

nkoenig commented May 26, 2020

@JShep1 , we need this for SubT. Are you able to pick this up and target and MVP to blueprint?

@JShep1
Copy link

JShep1 commented May 26, 2020

@nkoenig Sure, I'll prioritize this issue and try to get started later today/tomorrow.

@nkoenig
Copy link
Contributor

nkoenig commented May 26, 2020

Awesome, thanks!

@chapulina
Copy link
Contributor

Just clarified with @nkoenig and @JShep1 that I'll take this one and John will work on #31.

@chapulina chapulina assigned chapulina and unassigned JShep1 May 26, 2020
@chapulina chapulina added the close the gap Features from Gazebo-classic label May 29, 2020
@chapulina chapulina added the 📜 blueprint Ignition Blueprint label Jun 2, 2020
@chapulina chapulina linked a pull request Jul 20, 2020 that will close this issue
2 tasks
@chapulina chapulina removed this from To do in Core development Jul 20, 2020
@peci1
Copy link
Contributor

peci1 commented Aug 18, 2020

Hasn't this been resolved? I can launch the SubT simulator pulling local models when I pass localModel:=true.

@iche033
Copy link
Contributor Author

iche033 commented Aug 18, 2020

I think for subt, if you don't have the model in fuel cache, the materials will still fail to load with localModel:=true. Related issue #286

@chapulina
Copy link
Contributor

I believe this has been solved and is available on:

  • Blueprint since 2.24.0
  • Citadel since 3.3.0
  • Dome since 4.0.0~pre1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint close the gap Features from Gazebo-classic enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants