Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Multicoptor Control system to include nested model inertial params #1450

Merged
merged 6 commits into from
May 6, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 19, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Updated the multicoptor velocity control system's inertial computation to include nested models. With this change, the controller will now be able to generate more thrusts when a higher motor_constant is specified. Before this change, the drone will not be able to take-off. This is useful when adding payloads (in the form of nested models) with heavy mass to the drone platform

An integration test is added for this use case.

Here is an example of it working in our test environment:

uav_suction_gripper_small

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from chapulina as a code owner April 19, 2022 19:19
@osrf-triage osrf-triage added this to Inbox in Core development Apr 19, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 19, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina added the mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/ label Apr 20, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Apr 20, 2022
@chapulina chapulina requested a review from mjcarroll May 2, 2022 18:36
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1450 (fc7a0ce) into ign-gazebo6 (269c9b9) will not change coverage.
The diff coverage is n/a.

❗ Current head fc7a0ce differs from pull request most recent head 470cc2b. Consider uploading reports for the commit 470cc2b to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1450   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270da60...470cc2b. Read the comment docs.

@j-rivero j-rivero removed this from In review in Core development May 6, 2022
@iche033 iche033 merged commit 52d12f1 into ign-gazebo6 May 6, 2022
@iche033 iche033 deleted the multicopter_control_nested branch May 6, 2022 17:01
@chapulina chapulina added this to Inbox in Core development via automation May 9, 2022
@chapulina chapulina moved this from Inbox to Done in Core development May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants