Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: release GIL when running server #1458

Merged
merged 2 commits into from Apr 26, 2022

Conversation

dlech
Copy link
Contributor

@dlech dlech commented Apr 26, 2022

馃 Bug fix

Fixes #

Summary

Since running the server can be a blocking function, we need to release the GIL so that other Python threads can run. This also means we no longer need to poll for the server to finish running by setting the blocking argument to True.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Since running the server can be a blocking function, we need to release
the GIL so that other Python threads can run. This also means we no
longer need to poll for the server to finish running by setting the
blocking argument to True.

Signed-off-by: David Lechner <david@pybricks.com>
@dlech dlech requested a review from chapulina as a code owner April 26, 2022 02:27
@github-actions github-actions bot added the 馃彲 fortress Ignition Fortress label Apr 26, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 26, 2022
Core development automation moved this from Inbox to In review Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1458 (168e797) into ign-gazebo6 (07bbeb2) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo6    #1458   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 07bbeb2...168e797. Read the comment docs.

@ahcorde ahcorde merged commit 0a5828e into gazebosim:ign-gazebo6 Apr 26, 2022
Core development automation moved this from In review to Done Apr 26, 2022
@dlech dlech deleted the release-gil branch April 26, 2022 15:56
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Apr 27, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants