Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enviroment system loading mechanism #1842

Merged
merged 33 commits into from
Oct 3, 2023
Merged

Fix enviroment system loading mechanism #1842

merged 33 commits into from
Oct 3, 2023

Commits on Dec 20, 2022

  1. Fix enviroment system loading mechanism 

    Currently, there is an issue with the way the Environment loader plugin loads data. In particular it directly writes to the ECM. While this makes sense intuitively, it does not work in practice as the GUI runs on a client process while systems that use it run on the server. This PR fixes this issue by introducing a topic through which the GUI may load Environment Data on the server.

TODO:
- [ ] This commit breaks the visuallization plugin. Fix it so the visuallization plugin runs the data sampling off the server plugin.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
    @arjo129
    arjo129 committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    ee16b8d View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. small changes 

    Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
    @arjo129
    arjo129 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2ce77fc View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Working on porting the visuals 

    Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
    @arjo129
    arjo129 committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    3829724 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Actually send message for loading from ui to environment preload plugin. 

    Visuallization still goes 💥

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f0d1866 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Rewrite EnvironmentVisualization Widget to be simpler. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    9b684cf View commit details
    Browse the repository at this point in the history

  2. fix crashes. 

    Vis still not working

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    dd24227 View commit details
    Browse the repository at this point in the history

  3. Get a different 💥 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    712ebe0 View commit details
    Browse the repository at this point in the history

  4. Works some times. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    d722ad8 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Fixed synchronization issues. 

    Now left with one more crash that needs debugging when "play" is hit.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    87586d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. No more 💥s 🎉 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    77f5472 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. style 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    882edbe View commit details
    Browse the repository at this point in the history

  2. Sprinkled with healthy dose of Doxygen 

    Also refactored the visualization tool out.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ea93a1b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Style 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    4fd5c9e View commit details
    Browse the repository at this point in the history

  2. More style fixes 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    d7c34c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Fix Typo with unit map 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    7af4af9 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    57b949b View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Style fixes 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    afcf5c6 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect use of path. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6b56a43 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Merge branch 'gz-sim7' into arjo/fix/environment_system

    @mjcarroll
    mjcarroll committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    8779e84 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Fix example loading issues. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    c2708db View commit details
    Browse the repository at this point in the history

  2. Merge branch 'arjo/fix/environment_system' of github.com:gazebosim/gz… 

    …-sim into arjo/fix/environment_system
    @arjo129
    arjo129 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    c30639a View commit details
    Browse the repository at this point in the history

  3. style 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    54c42b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Update src/systems/environment_preload/VisualizationTool.cc 

    Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo129@gmail.com>
    @arjo129 @mabelzhang
    arjo129 and mabelzhang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    fe1bc7c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Adds a warning regarding loading plugins. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3cf7896 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin' into arjo/fix/environment_system

    @arjo129
    arjo129 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    36e7cc4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'arjo/fix/environment_system' of github.com:gazebosim/gz… 

    …-sim into arjo/fix/environment_system
    @arjo129
    arjo129 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f90ef4f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Automatically loads plugin if missing 

    This commit automatically loads the environment preload plugin if it is
missing.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6b2c398 View commit details
    Browse the repository at this point in the history

  2. Address some feedback I missed 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    85b6eac View commit details
    Browse the repository at this point in the history

  3. Address some feedback 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    04a3858 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Fixes issue described by @iche033. 

    However fix depends on gazebosim/gz-math#551

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e3ed11a View commit details
    Browse the repository at this point in the history

  2. style 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4d0a034 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Fixed failing tests 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129
    arjo129 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    0672777 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge branch 'gz-sim7' into arjo/fix/environment_system

    @iche033
    iche033 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9daebc8 View commit details
    Browse the repository at this point in the history