-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up Resource Spawner load time by fetching model list asynchronously #1962
Conversation
…usly Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
This one has conflicts now. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement. LGTM with green CI!
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1962 +/- ##
===============================================
- Coverage 78.04% 78.03% -0.02%
===============================================
Files 255 255
Lines 15080 15082 +2
===============================================
Hits 11769 11769
- Misses 3311 3313 +2
|
🦟 Bug fix
Fixes #1253
Summary
The main reason that the Resource Spawner took a long time to load is that it tried to fetch the list of all available models on Fuel instead of just the selected owner. And it did that while blocking the Qt thread, so the user was unable to interact with the GUI while the model list was being fetched. The approach I've taken is to only fetch the list of models for the default owner ("openrobotics") and allow users to add/remove any owner they want. The fetching is also done in a separate thread so as to not block the GUI.
This currently does not preserve the list of owners added by the user. I thought it would be better to add that in a follow up PR at a future time.
Needs gazebosim/gz-fuel-tools#350
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.