Enable GzWeb visualization of markers by republishing service requests on a topic #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
mjcarroll
approved these changes
May 18, 2023
ahcorde
reviewed
May 18, 2023
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1994 +/- ##
===============================================
- Coverage 78.04% 70.75% -7.30%
===============================================
Files 255 262 +7
Lines 15080 16759 +1679
===============================================
+ Hits 11769 11857 +88
- Misses 3311 4902 +1591
|
iche033
reviewed
May 18, 2023
azeey
changed the title
iche033
approved these changes
May 22, 2023
|
The ABI checker is unhappy because I made the MarkerManager have the correct visibility. This okay because it resolves an error case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
The MarkerManager utilizes services for updating visual markers. GzWeb can't listen into services, and instead requires topics. This PR enables GzWeb visualization of markers by republishing service requests on a topic.
Test it
An integration test has been added.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.