Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image links in Blender procedural generation tutorial #1996

Merged
merged 2 commits into from
May 24, 2023

Conversation

mabelzhang
Copy link
Contributor

🦟 Bug fix

Summary

Images in the Blender procedural generation tutorial are not showing up on the rendered page (they only show up in GitHub)
https://gazebosim.org/api/sim/7/blender_procedural_datasets.html

Need to use raw image links.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development May 24, 2023
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 24, 2023
Core development automation moved this from Inbox to In review May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1996 (fcc6be4) into gz-sim7 (42c285e) will not change coverage.
The diff coverage is n/a.

❗ Current head fcc6be4 differs from pull request most recent head 0e90384. Consider uploading reports for the commit 0e90384 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #1996   +/-   ##
========================================
  Coverage    64.97%   64.97%           
========================================
  Files          353      353           
  Lines        28600    28600           
========================================
  Hits         18584    18584           
  Misses       10016    10016           

see 2 files with indirect coverage changes

@mjcarroll mjcarroll merged commit 3bde4b5 into gz-sim7 May 24, 2023
10 of 13 checks passed
Core development automation moved this from In review to Done May 24, 2023
@mjcarroll mjcarroll deleted the mabelzhang/fix_blender_procedural_tutorial branch May 24, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants