Adds bindings for the Sensor convenience class #2042

Voldivh · 2023-07-19T19:40:39Z

🎉 New feature

Summary

This PR adds bindings for the Sensor convenience class.

Checklist

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

codecov · 2023-07-19T20:59:05Z

Codecov Report

Merging #2042 (94695f2) into main (0cf11dc) will increase coverage by 0.02%.
The diff coverage is 62.50%.

❗ Current head 94695f2 differs from pull request most recent head d17a53d. Consider uploading reports for the commit d17a53d to get more accurate results

@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
+ Coverage   65.40%   65.42%   +0.02%     
==========================================
  Files         316      317       +1     
  Lines       29975    29999      +24     
==========================================
+ Hits        19605    19628      +23     
- Misses      10370    10371       +1

Files Changed	Coverage Δ
python/src/gz/sim/Sensor.cc	`60.86% <60.86%> (ø)`
python/src/gz/sim/_gz_sim_pybind11.cc	`100.00% <100.00%> (ø)`

... and 3 files with indirect coverage changes

ahcorde

tests ?

python/src/gz/sim/Sensor.cc

ahcorde · 2023-07-19T21:07:00Z

python/src/gz/sim/Sensor.hh

@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2021 Open Source Robotics Foundation


Suggested change

* Copyright (C) 2021 Open Source Robotics Foundation

* Copyright (C) 2023 Open Source Robotics Foundation

I still see 2021

Weird I might have changed in other place and forgot about this one. It should be done now.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

python/src/gz/sim/Sensor.cc

ahcorde · 2023-08-17T15:01:01Z

python/src/gz/sim/Sensor.hh

@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2021 Open Source Robotics Foundation


I still see 2021

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

azeey

LGTM! Just one comment about SensorTopic.

python/test/sensor_TEST.py

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Feedback addressed

Voldivh added 3 commits July 18, 2023 08:12

Adds bindings for the world convenience class

bd9846e

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds initial tests

1db3735

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Use alias on bindings

df9608e

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

osrf-triage added this to Inbox in Core development Jul 19, 2023

Voldivh marked this pull request as ready for review July 19, 2023 20:12

Voldivh requested a review from mjcarroll as a code owner July 19, 2023 20:13

ahcorde requested changes Jul 19, 2023

View reviewed changes

Core development automation moved this from Inbox to In review Jul 19, 2023

Base automatically changed from nkoenig/7-to-main to main July 20, 2023 18:06

Voldivh added 4 commits July 25, 2023 18:58

Adds test to this class

40423f8

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds missing dependency for CI

4a013a6

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds dependency to packages.apt

55e5bb7

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds newline at the end of file

863b61b

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Voldivh changed the base branch from main to voldivh/python_bindings_joint July 27, 2023 14:28

Voldivh requested a review from mabelzhang as a code owner July 27, 2023 14:28

Voldivh force-pushed the voldivh/python_bindings_sensor branch from cccb6cb to f7ed1e6 Compare July 27, 2023 14:29

Renames the world sdf file

e7c955b

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023

Voldivh added 2 commits August 1, 2023 12:53

Adds the rest of the test

cbcdf3d

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Removes trailing whitespace

aa435d6

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Voldivh force-pushed the voldivh/python_bindings_joint branch from ca7ec46 to a0b8568 Compare August 1, 2023 18:10

Voldivh force-pushed the voldivh/python_bindings_sensor branch from 77022c1 to 1ab1533 Compare August 1, 2023 18:24

Voldivh and others added 7 commits August 8, 2023 10:31

Adds import dependency files

a97358d

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds newline at end of files

99c9de0

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Address reviewer feedback

786edbf

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

Include correct export header

4289f00

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

Adds model bindings

5b48e80

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Use alias on bindings

db2d815

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds test and fixes documentation

1aeeb53

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Voldivh force-pushed the voldivh/python_bindings_sensor branch from 1ab1533 to 4050b98 Compare August 8, 2023 15:59

Voldivh and others added 14 commits August 10, 2023 13:19

Adds copy constructor

7de886c

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds copy constructor

49dfce9

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Removes whitespace

0608135

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Removes whitespace

35a7f66

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Merge branch 'main' into voldivh/python_bindings_joint

462a9a9

Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>

Modifies the use of the null entity variable

5237f1b

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds bindings for the Sensor class

578651c

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds test for the bindings

84f8c89

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds whitespace at the end of comment

e1e8168

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Modifies import dependencies

7ffc6a8

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Adds copy constructor

fea97b4

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Removes whitespace

aea15ab

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Modifies the use of the null entity variable

4a1e4f2

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Resolve merge conflicts

bdb4d6f

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Voldivh requested review from jennuine and iche033 as code owners August 15, 2023 20:41

Actually resolves the merge conflict

b01d182

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Base automatically changed from voldivh/python_bindings_joint to main August 17, 2023 02:04

Voldivh and others added 2 commits August 17, 2023 07:30

Merge branch 'main' into voldivh/python_bindings_sensor

cc8a985

Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>

Modifies the type of sensor to torque_force

0d70b41

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

ahcorde previously requested changes Aug 17, 2023

View reviewed changes

Removes unused library import

4a8b23f

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

azeey requested a review from ahcorde August 17, 2023 16:57

azeey approved these changes Aug 17, 2023

View reviewed changes

python/test/sensor_TEST.py Outdated Show resolved Hide resolved

Adds plugins for sensor topic

d17a53d

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

azeey enabled auto-merge (squash) August 18, 2023 18:46

azeey merged commit b16de11 into main Aug 21, 2023
7 of 10 checks passed

azeey deleted the voldivh/python_bindings_sensor branch August 21, 2023 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds bindings for the Sensor convenience class #2042

Adds bindings for the Sensor convenience class #2042

Voldivh commented Jul 19, 2023

codecov bot commented Jul 19, 2023 •

edited

Loading

ahcorde left a comment

ahcorde Jul 19, 2023

Voldivh Jul 27, 2023

ahcorde Aug 17, 2023

Voldivh Aug 17, 2023

ahcorde Aug 17, 2023

azeey left a comment

		@@ -0,0 +1,40 @@
		/*
		* Copyright (C) 2021 Open Source Robotics Foundation

	* Copyright (C) 2021 Open Source Robotics Foundation
	* Copyright (C) 2023 Open Source Robotics Foundation

Adds bindings for the Sensor convenience class #2042

Adds bindings for the Sensor convenience class #2042

Conversation

Voldivh commented Jul 19, 2023

🎉 New feature

Summary

Checklist

codecov bot commented Jul 19, 2023 • edited Loading

Codecov Report

ahcorde left a comment

Choose a reason for hiding this comment

ahcorde Jul 19, 2023

Choose a reason for hiding this comment

Voldivh Jul 27, 2023

Choose a reason for hiding this comment

ahcorde Aug 17, 2023

Choose a reason for hiding this comment

Voldivh Aug 17, 2023

Choose a reason for hiding this comment

ahcorde Aug 17, 2023

Choose a reason for hiding this comment

azeey left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 19, 2023 •

edited

Loading