Removing ignition

[nkoenig]

🎉 New feature

Removing "ignition"

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[ahcorde]

typo

[azeey]

Looks good. My main concern is if we should remove support for using "ignition" in SDF files. Unlike code, those files are meant to work with multiple versions of Gazebo.

[codecov]

Codecov Report

Merging #2055 (f8a6f50) into main (5846393) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 33.33%.

❗ Current head f8a6f50 differs from pull request most recent head 654c624. Consider uploading reports for the commit 654c624 to get more accurate results

@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
- Coverage   65.32%   65.31%   -0.01%     
==========================================
  Files         321      321              
  Lines       30303    30272      -31     
==========================================
- Hits        19795    19772      -23     
+ Misses      10508    10500       -8     

Files Changed	Coverage Δ
include/gz/sim/System.hh	100.00% <ø> (ø)
include/gz/sim/Util.hh	100.00% <ø> (ø)
include/gz/sim/components/Model.hh	93.75% <ø> (ø)
src/ServerConfig.cc	90.86% <0.00%> (+2.81%)	⬆️
src/ServerPrivate.cc	82.23% <ø> (ø)
src/SystemLoader.cc	63.86% <ø> (-7.57%)	⬇️
.../plugins/component_inspector/ComponentInspector.cc	5.57% <0.00%> (ø)
src/systems/log/LogPlayback.cc	59.91% <ø> (ø)
src/systems/physics/Physics.cc	72.38% <ø> (+0.12%)	⬆️
.../systems/triggered_publisher/TriggeredPublisher.hh	100.00% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

[mjcarroll]

This now needs #2087 to build

[nkoenig]

Looks good. My main concern is if we should remove support for using "ignition" in SDF files. Unlike code, those files are meant to work with multiple versions of Gazebo.

I believe we have followed the tick-tock approach where deprecation warnings have been given to users to modify their SDF. Standard practice is to follow the tick with the tock.

[azeey]

I believe we have followed the tick-tock approach where deprecation warnings have been given to users to modify their SDF. Standard practice is to follow the tick with the tock.

Fair enough.

[iche033]

changes look goo to me. Just need to re-run CI when it's ready.

[mjcarroll]

Now blocked on gazebosim/gz-msgs#380 and #2103

[nkoenig]

Now blocked on gazebosim/gz-msgs#380 and #2103

What are you doing to me?

[mjcarroll]

What are you doing to me?

Jumping on the Windows grenade for you 🙃

[mjcarroll]

It's not actually blocked at this point, Windows CI isn't going to pass until those two PRs are in. One for gz-msgs generation stuff, one for disabling pybind on windows which hadn't been forward ported yet.

I'm good with merging with those caveats.

[nkoenig]

A windows grenade seems like the most ineffectual grenade ever. Let me know when the grenade is done updating.

I'll wait...

[mjcarroll]

CI Except Windows looks okay