Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the dart6.13 packages to CI #2203

Closed
wants to merge 1 commit into from

Conversation

j-rivero
Copy link
Contributor

馃 Bug fix

Summary

Somehow we were not using DART packages in our CI or I don't see them listed here. Add the ones in our stable repository.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@github-actions github-actions bot added the 馃幍 harmonic Gazebo Harmonic label Oct 11, 2023
@azeey
Copy link
Contributor

azeey commented Oct 11, 2023

The direct dependence on DART was removed #2187 intentionally. Can we not just rely on gz-physics-dartsim?

@j-rivero
Copy link
Contributor Author

The direct dependence on DART was removed #2187 intentionally. Can we not just rely on gz-physics-dartsim?

Oh, that is totally right.

@j-rivero j-rivero closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃幍 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants