Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom_sensor_system example #2208

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 16, 2023

🦟 Bug fix

Summary

The custom_sensor_system example and CI test broke when gz-sensors' main branch was bumped to gz-sensors9. This fixes by using the gz-sensors8 branch.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mjcarroll as a code owner October 16, 2023 14:41
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2208 (0e1170a) into gz-sim8 (8c2fb9b) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e1170a differs from pull request most recent head 9e62043. Consider uploading reports for the commit 9e62043 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim8    #2208   +/-   ##
========================================
  Coverage    65.92%   65.92%           
========================================
  Files          323      323           
  Lines        30719    30719           
========================================
  Hits         20251    20251           
  Misses       10468    10468           

@azeey azeey merged commit 71d965a into gazebosim:gz-sim8 Oct 16, 2023
6 of 8 checks passed
@azeey azeey deleted the fix_example branch October 16, 2023 18:58
mabelzhang pushed a commit that referenced this pull request Nov 1, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants