Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DLL linkage/visibility issues #2254

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix DLL linkage/visibility issues #2254

merged 2 commits into from
Nov 22, 2023

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Nov 21, 2023 •
edited
Loading

This was caused by rebuilding the same file as a library and standalone executable. This simply separates the two.

Closes #2251

@mjcarroll
Fix DLL linkage/visibility issues
bfc0e30 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 21, 2023
@mjcarroll mjcarroll mentioned this pull request Nov 21, 2023
Closed
ahcorde
ahcorde previously requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/github/workspace/src/cmd/runGui_main.cc:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]

@mjcarroll
Add copyright and fix link
5e821e0 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Copy link
Contributor Author

There is a failing Windows test here, but the linkage warning are gone.

@scpeters scpeters dismissed ahcorde’s stale review November 21, 2023 23:50

copyright has been fixed

@scpeters scpeters merged commit a88340b into gz-sim7 Nov 22, 2023
8 of 9 checks passed
@scpeters scpeters deleted the mjcarroll/fix_dll_visibility branch November 22, 2023 01:53
@mjcarroll mjcarroll self-assigned this Nov 27, 2023
@Blast545 Blast545 mentioned this pull request Jun 3, 2024
Closed
mjcarroll added a commit that referenced this pull request Jun 24, 2024
@mjcarroll
Fix DLL linkage/visibility issues (#2254)
51482ec 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll mentioned this pull request Jun 24, 2024
Merged
azeey pushed a commit that referenced this pull request Jul 10, 2024
@mjcarroll @azeey
Fix DLL linkage/visibility issues (#2254)
727bbf0 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
azeey pushed a commit that referenced this pull request Jul 11, 2024
@mjcarroll @azeey
Fix DLL linkage/visibility issues (#2254)
a2a9c53 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@ahcorde ahcorde ahcorde left review comments

Assignees

@mjcarroll mjcarroll

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows warnings about inconsistent dll linkage when building runGui.exe
3 participants
@mjcarroll @ahcorde @scpeters