Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and set bullet solver iterations #2351

Merged
merged 4 commits into from
May 31, 2024
Merged

Parse and set bullet solver iterations #2351

merged 4 commits into from
May 31, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 1, 2024

🎉 New feature

Summary

Added support for users to configure the bullet solver iterations.

It parses the //world/physics/bullet/solver/iters SDF param and sets that value to the physics engine using the new Solver feature, SetSolversIterations, introduced in gazebosim/gz-physics#609.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 1, 2024
include/gz/sim/components/Physics.hh Show resolved Hide resolved
src/LevelManager.cc Show resolved Hide resolved
src/SdfEntityCreator.cc Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from ahcorde May 31, 2024 10:11
@iche033 iche033 merged commit 4c34f4e into main May 31, 2024
7 checks passed
@iche033 iche033 deleted the set_solver_iterations branch May 31, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants