Fix CMake warnings in Noble #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
|
#2387 is close to being merged and it has changes to examples/standalone/gtest_setup/CMakeLists.txt. Should we wait for that? |
|
@azeey I think if that one gets merged, this PR won't be needed, as the complete FetchContent logic is removed. I didn't saw that one, if that's close to be merged I'll just put this one as a draft and close/continue if needed be. |
|
@ros-pull-request-builder retest this please |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
approved these changes
May 28, 2024
| @@ -10,14 +10,14 @@ set(GZ_SIM_VER ${gz-sim8_VERSION_MAJOR}) | |||
| include(FetchContent) | |||
| FetchContent_Declare( | |||
| googletest | |||
| DOWNLOAD_EXTRACT_TIMESTAMP TRUE | |||
There was a problem hiding this comment.
I moved this argument above URL because older versions of CMake handled it as part of the URL and failed.https://build.osrfoundation.org/job/gz_sim-ci-pr_any-jammy-amd64/625/testReport/junit/(root)/_init_/Plugins_ExamplesBuild/
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Fixes CMake warnings in Noble
Summary
Removing the deprecated Dart (Testing tool) include and explicitly setting the timestamp option when fetch declaring googleTest in a specific example.
Reference build:
https://build.osrfoundation.org/job/gz_sim-ci-gz-sim8-noble-amd64/18/
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.