-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Track and Follow options in gui EntityContextMenu #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
This was referenced May 10, 2024
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-track-follow
branch
from
May 10, 2024 06:50
4c5879e
to
a1a384a
Compare
ahcorde
previously requested changes
May 10, 2024
Co-authored-by: Alejandro Hern谩ndez Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-track-follow
branch
from
May 10, 2024 16:50
4346c28
to
96b602a
Compare
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
jennuine
approved these changes
May 17, 2024
Co-authored-by: Jenn Nguyen <jenn.nguyen02@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
ahcorde
added
the
needs upstream release
Blocked by a release of an upstream library
label
May 20, 2024
@osrf-jenkins run tests |
1 similar comment
@osrf-jenkins run tests |
bperseghetti
dismissed
ahcorde鈥檚 stale review
May 22, 2024 18:52
Dismissed review as all requested changes were made.
ahcorde
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Summary
I would like to thank NXP for their support in enabling this work.
Depends on:
This adds a new
/gui/track
topic using the CameraTrack message to control multiple types of tracking and associated pgain(s), target(s) and offset(s). Furthermore it publishes a tracking camera status CameraTrack message on/gui/currently_tracked
This also adds an 3 unique follow modes and a tracking mode all able to be set from either the
/gui/track
topic or more ideally from the user gui.The 3 follow modes are in a submenu under the right click top level menu
Follow Options >
and are:Follow - Traditional follow mode where camera follows and tracks the same target.
Free Look - Enables a user to follow a target while still using an input device (IE mouse) to look around.
Look At - Only enabled after already selecting a primary object to follow, this allows a user to track a unique secondary target while following the primary target.
The other right click top level menu item added is
Track
, where the gui camera can be moved anywhere in the simulator but will always track the selected object.These all respect using the escape key to stop any form of tracking.
Test it
Use these changes for collection-harmonic.yaml:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.