Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForceTorque system: improve readability #2403

Merged
merged 1 commit into from
May 13, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Improves readability

Summary

This adds some comments and uses structured bindings in range-based for loops to improve readability. It also adds const to unmodified variables in a loop.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This adds some comments and uses structured bindings
in range-based for loops to improve readability.
It also adds const to unmodified variables in a loop.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner May 13, 2024 13:39
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label May 13, 2024
@scpeters scpeters merged commit 3c2a3ce into main May 13, 2024
6 of 7 checks passed
@scpeters scpeters deleted the scpeters/force_torque_readability branch May 13, 2024 18:05
scpeters added a commit that referenced this pull request May 14, 2024
This adds some comments and uses structured bindings
in range-based for loops to improve readability.
It also adds const to unmodified variables in a loop.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request May 14, 2024
This adds some comments and uses structured bindings
in range-based for loops to improve readability.
It also adds const to unmodified variables in a loop.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants