Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase cmake comment about CMP0077 #2419

Merged
merged 1 commit into from
May 29, 2024
Merged

Rephrase cmake comment about CMP0077 #2419

merged 1 commit into from
May 29, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Improves a cmake comment

Summary

While updating cmake logic as part of gazebosim/gz-cmake#350, I noticed a typo in the cmake version in a comment about setting policy CMP0077 (13.13 instead of 3.13), so I've fixed the typo and also rephrased the comment to refer to the cmake_minimum_version instead of the cmake version, since the policy would have no effect on old versions of cmake; it only affects newer versions of cmake while the cmake_minimum_version is set to a version older than 3.13.

cc @Blast545

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner May 29, 2024 11:18
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 29, 2024
@azeey azeey merged commit 0b4585a into ign-gazebo6 May 29, 2024
8 of 10 checks passed
@azeey azeey deleted the scpeters/cmp0077 branch May 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants