Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sdf::Geometry::EMPTY in conversions #2430

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 3, 2024

🎉 New feature

Summary

Handle sdf::Geometry::EMPTY in Conversions.cc.

Test it

Test added to Conversions_TEST.cc

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig requested a review from mjcarroll as a code owner June 3, 2024 12:59
@nkoenig nkoenig changed the base branch from gz-sim8 to gz-sim7 June 3, 2024 13:00
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 3, 2024
@mjcarroll mjcarroll enabled auto-merge (squash) June 3, 2024 15:13
@nkoenig nkoenig added 🌱 garden Ignition Garden and removed 🎵 harmonic Gazebo Harmonic labels Jun 3, 2024
@azeey
Copy link
Contributor

azeey commented Jun 4, 2024

Changing the base branch seems to have caused some issues with CI. I'm going to try closing and opening the PR.

@azeey azeey closed this Jun 4, 2024
auto-merge was automatically disabled June 4, 2024 15:12

Pull request was closed

@azeey azeey reopened this Jun 4, 2024
@azeey azeey merged commit 49ab5c6 into gz-sim7 Jun 5, 2024
12 of 14 checks passed
@azeey azeey deleted the nkoenig/handle-geom-empty branch June 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants