Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update sensors if it a triggered sensor #2443

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 14, 2024

🦟 Bug fix

Depends on gazebosim/gz-sensors#441

Summary

Currently the logic for checking active sensors ignores the triggered property of a camera. So as the result, when you subscribe to any triggered sensors, they become "active" (added to the activeSensors list) and they perform unnecessary prerender updates even when they don't have pending triggers. This PR adds a check for the triggered property of the sensor to filter them out when checking for active sensors.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 14, 2024
@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label Jun 14, 2024
@iche033
Copy link
Contributor Author

iche033 commented Jun 14, 2024

@osrf-jenkins run tests please

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Jun 14, 2024

The ModelCommandAPI unit test failure caught by the gz_sim-ci-pr_any-jammy-amd64 build should be fixed in #2444

@iche033 iche033 merged commit 2297be7 into gz-sim8 Jun 14, 2024
6 of 8 checks passed
@iche033 iche033 deleted the sensors_triggered_fix branch June 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants